dsmiley commented on code in PR #4652:
URL: https://github.com/apache/solr/pull/4652#discussion_r3696075098
##########
solr/core/src/java/org/apache/solr/search/DisMaxQParser.java:
##########
@@ -227,6 +227,9 @@ protected Query getPhraseQuery(String userQuery,
SolrPluginUtils.DisjunctionMaxQ
* matched those phrases but do match looser phrases.
*/
String userPhraseQuery = userQuery.replace("\"", "");
+ if (userPhraseQuery.trim().indexOf(' ') < 0) {
+ return null;
+ }
Review Comment:
this feels shoved in here given the statement above and below. This could
go *before* the quote processing; certainly before its comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
