adityamparikh opened a new pull request, #177:
URL: https://github.com/apache/solr-mcp/pull/177
Verified findings from a CodeRabbit review.
- `DockerImageHttpIntegrationTest` read `solr.test.image` with **no
default**, so `DockerImageName.parse` received `null` whenever the property was
unset. Now uses the same default as `DockerImageMcpClientStdioIntegrationTest`.
- `SampleClient` asserted an exact tool count of **8**; the server exposes
**11**, and the list went stale as soon as `create-collection`, `add-fields`
and `add-field-types` were added. Now a lower bound plus per-name presence, so
adding a tool will not break it.
- `CollectionServiceIntegrationTest` required `select.errors()` and
`select.timeouts()` to be `null`. Solr may omit these counters **or** report an
explicit `0`, and both mean nothing went wrong — the test depended on which.
- `McpClientIntegrationTestBase.assertNotError` cast the first content item
to `TextContent`, so a non-text error payload raised `ClassCastException` and
**hid the actual failure message**.
- Renamed `SolrConfigTest` → `SolrConfigIntegrationTest`: it is
`@Tag("integration")` and starts Testcontainers, contradicting the project's
`*Test` = unit / `*IntegrationTest` = integration convention.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
