gerlowskija commented on PR #4699: URL: https://github.com/apache/solr/pull/4699#issuecomment-5182838629
Hey @dsmiley - thanks for the review. I agree with all your comments by and large, but have scope concerns. Specifically: I'd love for all of our test API calls to use the correct 'SolrRequest' type (e.g. LukeRequest for `/admin/luke`, GSR for `/analysis/field`). But that's a slightly larger change than just dropping 'qt', and multiplied out across the hundreds of these SolrJ and test-helper usages (only a fraction of which are in this PR) it would definitely impact velocity. So I wanted to ask: how strongly do you feel about fixing both things in the same sweep of the codebase? If you feel strongly I'll make slower progress but also address this sort of stuff. But if you don't, I'll stick pretty strictly to "just" ripping out qt as my initial pass here did. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
