KhushJain commented on code in PR #4691:
URL: https://github.com/apache/solr/pull/4691#discussion_r3717338283
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/metrics/StdMetric.java:
##########
@@ -75,11 +70,28 @@ private void init(String functionName, String columnName,
boolean outputLong) {
}
@Override
- public void update(Tuple tuple) {}
+ public void update(Tuple tuple) {
+ Object o = tuple.get(columnName);
+ double val;
+ if (o instanceof Double d) {
Review Comment:
Agreed on the quirky instanceof pattern, but keeping it consistent with all
its siblings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
