janhoy commented on code in PR #4710:
URL: https://github.com/apache/solr/pull/4710#discussion_r3730812444
##########
solr/core/src/java/org/apache/solr/cli/StatusTool.java:
##########
@@ -168,6 +168,7 @@ private void printProcessStatus(SolrProcess process,
CommandLine cli) throws Exc
CLIO.out(pidUrl);
} else {
if (maxWaitSecs > 0) {
+ // Used by Windows start script, which passes the port of the newly
started instance
Review Comment:
As I wrote in the "PS" above, I think this is mature enough now to replace
the bash-scripting around waiting for solr, parsing PID files etc. And we
support both linux and windows pid files (yes they are different). But I'd like
to do that as a follow-up once until this has been in the hands of users for
some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
