dsmiley commented on code in PR #4655:
URL: https://github.com/apache/solr/pull/4655#discussion_r3760120339
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##########
@@ -78,65 +76,70 @@ public class HttpJdkSolrClient extends HttpSolrClient {
protected HttpClient httpClient;
+ /**
+ * Executor used to stream (produce) request bodies into the pipe consumed
by the JDK HttpClient.
+ * This is the "producer" side and may be supplied by the caller.
+ */
protected ExecutorService executor;
+ /** Dedicated executor handed to the JDK HttpClient */
+ protected ExecutorService httpClientExecutor;
+
Review Comment:
IMO this is inverted. Like the jetty client, the builder's executor should
be for the HttpClient.
It's maybe debatable if 2 vs 1 executor is needed; it depends on the
construction of the executor. Our default construction is fine but if someone
were to customize it to introduce a limit, then there's a deadlock risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
