iprithv opened a new pull request, #4726:
URL: https://github.com/apache/solr/pull/4726
GCSBackupRepository.copyIndexFileTo currently:
Swallows all exceptions via a bare catch (Exception e) { log.info("Here's an
exception e", e); }, so a failed or incomplete restore can look successful.
Uses while (readChannel.read(buffer) > 0), which is incorrect per
ReadableByteChannel.read: a 0 return is not EOF, so the loop can terminate
early and leave a truncated destination file. The S3 equivalent already uses !=
-1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
