epugh commented on code in PR #4728:
URL: https://github.com/apache/solr/pull/4728#discussion_r3770303545
##########
solr/core/src/test/org/apache/solr/handler/TestSnapshotCoreBackup.java:
##########
@@ -369,6 +375,101 @@ public void testBackupAfterSoftCommit() throws Exception {
admin.close();
}
+ /**
+ * Backups run asynchronously, so the status reported to
/replication?command=details must
+ * describe a snapshot that is still running -- not stay silent (or keep
describing the previously
+ * completed snapshot) until it finishes.
+ *
+ * <p>Rather than racing a live backup by polling "details", this collects
every status the
+ * handler would have published and asserts on the whole sequence, which is
deterministic.
+ */
+ public void testBackupReportsProgressWhileRunning() throws Exception {
Review Comment:
is this a pattern that we follow elsewhere in Solr for these types of
things?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
