dsmiley commented on code in PR #4724:
URL: https://github.com/apache/solr/pull/4724#discussion_r3776299568
##########
solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java:
##########
@@ -119,11 +116,14 @@ SearchResult searchCollectorManagers(
return new SearchResult(scoreMode, ret);
}
- static boolean allowMT(DelegatingCollector postFilter, QueryCommand cmd) {
+ static boolean allowMT(DelegatingCollector postFilter, QueryCommand cmd,
boolean hasExecutor) {
Review Comment:
I find this method rather inelegant. It takes several args, one of which is
a boolean (problematic to discern meaning at call-site in Java; no named-args).
The method's only purpose is to decide yes/no on something. Notice that this
method takes a postFilter and we do a null check. I think it'd be slightly
improved to replace this boolean you added with the executor itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
