adityamparikh commented on PR #100:
URL: https://github.com/apache/solr-mcp/pull/100#issuecomment-5341390413
Closing as obsolete — this landed upstream via #176.
Current \`main\` (\`a84033b\`), `SchemaService.java:191`:
```java
return toJson(objectMapper, Map.of("error", String.valueOf(e.getMessage())));
```
That is this PR's change, and strictly better than it. This PR proposed:
```java
return toJson(objectMapper, Map.of("error", e.getMessage()));
```
`Map.of` rejects null values with an NPE, so on an exception whose
`getMessage()` is null (common for NPE and several SolrJ wrappers) this PR's
version would throw from inside the catch block and replace a JSON error
payload with a propagated NPE. Upstream's `String.valueOf(...)` avoids exactly
that.
No action needed — closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
