adityamparikh commented on PR #159: URL: https://github.com/apache/solr-mcp/pull/159#issuecomment-5341566330
@epugh re "looks like some lint checks failed" — I dug into this, and **the three red jobs are inherited from the branch point, not caused by this PR.** The split is the tell: `Build`, `Unit Tests` and `Integration Tests` all pass; only `nativeTest` and the two `native Docker image` jobs fail. This branch points at `582490b`, which predates two native-only fixes that have since landed on `main`: | Fix | Commit | What it repairs | |---|---|---| | #172 | `2809af2` | `DefaultMetaProvider` reflection hint — without it every Spring context refresh fails in native image with "Required no-arg constructor not found" | | #173 | `9e71cb4` | Docker image tag suffix used by the native integration tests | `main` measures green natively since those landed, so this is a stale-base problem rather than anything wrong with alias management. I opened y-luis-rojo/solr-mcp#2 against `feature/alias-management` to merge current `main` in. It is merge-only — no changes to @y-luis-rojo's code. Merging it should turn all three jobs green and make this PR mergeable. Two things I verified specifically, because a *clean* merge is exactly what hides them: 1. **The `AliasResult` native hint survived the merge.** `main` has been editing that same list (#180 dropped `FieldStats`), so the registration sits between upstream changes on both sides. It is still registered — had it been dropped, the alias tools would have serialized to empty JSON in native image only, which is about the worst failure mode to debug. 2. **`main` gained `SolrNativeHintsTest`**, a JVM-path test pinning those registrations. It passes against this branch. Locally on JDK 25 the merged result is clean for `compileJava`, `compileTestJava` and `spotlessCheck`. My approval from earlier still stands on the code itself — this is purely about getting CI honest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
