adityamparikh commented on PR #133:
URL: https://github.com/apache/solr-mcp/pull/133#issuecomment-5343825621
Closing as superseded — every part of this PR is already on `main`
(`a84033b`).
I checked each piece rather than assuming:
**1. All 10 `package-info.java` files exist upstream.** Both the 8
main-package ones (`collection`, `config`, `indexing`,
`indexing.documentcreator`, `schema`, `search`, `security`, `util`) and the 2
test-only ones (`containerization`, `observability`) — plus more that landed
with #179.
**2. The `build.gradle.kts` change is byte-identical upstream**, including
the comment. `main` already has:
```kotlin
option("NullAway:HandleTestAssertionLibraries", "true") // Teach NullAway
that JUnit assertNotNull narrows nullness
```
and the `compileTestJava` NullAway disable with the same ~30-sites rationale
comment this PR wrote.
**3. The `@Nullable` annotations are in place.** `CollectionUtils`, `Dtos`,
`JsonResponseParser` and `HttpSecurityConfiguration` are now
character-for-character what this branch proposed — 0 differing lines each.
**4. Nothing is left over.** Diffing this branch against `main` per file,
the only remaining differences are places where the branch is *behind*: it
would revert #166's `list-collections` remediation hint in `CollectionService`
and reintroduce a non-final local in `SearchService`. So rebasing it produces
either an empty diff or a regression — there is no residue worth keeping.
The one thing here that has **not** landed and is worth its own issue if
anyone wants it: NullAway is still disabled on `compileTestJava`, so the ~30
test sites that dereference production `@Nullable` values are still unchecked.
That was always scoped as a follow-up in this PR's own comment, and it survives
the close.
No action needed — closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
