adityamparikh commented on PR #185: URL: https://github.com/apache/solr-mcp/pull/185#issuecomment-5357684736
Closing as a duplicate of #175, which fixes the same bug and predates this by sixteen days. I filed issue #182 and opened this PR without finding #175 — my duplicate check searched issues for "facet" and found nothing, but I never searched pull requests. That's the gap. **#175 is also the better implementation.** It anchors on the full path `facet_counts/facet_fields/<field>`, so a key named `facet_fields` occurring elsewhere in a response can't be misinterpreted; this PR matched the bare key at any depth in the tree. The extra `facet_queries` / `facet_intervals` coverage here adds nothing either — Solr emits both as JSON objects, which already decode correctly via `convertObject`. The one thing this PR had that #175 lacked was an end-to-end test against real Solr. That has been ported over in adityamparikh/solr-mcp@e4d0646 and verified on #175's branch: reverting only its `JsonResponseParser` change makes the ported test fail with `ClassCastException`. Nothing here is lost. Review effort should go to #175. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
