adityamparikh commented on PR #110: URL: https://github.com/apache/solr-mcp/pull/110#issuecomment-5357781388
**Adopted #111's narrowing (506f2bb) so these two PRs no longer collide.** Both touch the same two catch clauses in `fetchCacheMetrics` / `fetchHandlerMetrics`. This PR was binding the exception for logging while keeping `RuntimeException`; #111 narrows it to `SolrException`. Whichever merged second would have conflicted, or silently reverted the other's intent — the worse outcome, since nothing would look wrong. This branch now carries the narrowed catch as well, so the end state is the same in either merge order. If #111 merges first this rebases cleanly; if this merges first, #111 becomes a no-op on these lines and keeps its `AGENTS.md` correction. Verified: `RemoteSolrException extends SolrException` in solrj 10.0.0, so Solr 10 still degrades to `null` where `/admin/mbeans` is gone. Full build green — 372 tests, 0 failures. Worth noting the two changes reinforce each other: narrowing the catch means unrelated runtime failures propagate instead of being reported as "metrics unavailable", and the `debug` logging added here is what makes the genuinely-unavailable case diagnosable rather than silent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
