Copilot commented on code in PR #3119: URL: https://github.com/apache/solr/pull/3119#discussion_r3823141775
########## solr/solr-ref-guide/gradle.lockfile: ########## @@ -161,6 +161,7 @@ org.glassfish.jersey.media:jersey-media-json-jackson:4.0.2=testRuntimeClasspath org.glassfish.jersey:jersey-bom:4.0.2=testRuntimeClasspath org.hamcrest:hamcrest:3.0=testCompileClasspath,testRuntimeClasspath org.javassist:javassist:3.30.2-GA=testRuntimeClasspath +org.jooq:joou-java-6:0.9.5=testRuntimeClasspath Review Comment: This module also resolves `joou-java-6:0.9.5`, for which no matching `.jar.sha1` file is included. Since checksum validation is performed per resolved artifact version, add `solr/licenses/joou-java-6-0.9.5.jar.sha1`; the existing 0.9.4 checksum only covers the version selected by the SQL module. ########## solr/solrj-streaming/gradle.lockfile: ########## @@ -161,6 +161,7 @@ org.glassfish.jersey:jersey-bom:4.0.2=jarValidation,testRuntimeClasspath org.hamcrest:hamcrest:3.0=jarValidation,testCompileClasspath,testRuntimeClasspath org.hsqldb:hsqldb:2.7.4=jarValidation,testRuntimeClasspath org.javassist:javassist:3.30.2-GA=jarValidation,testRuntimeClasspath +org.jooq:joou-java-6:0.9.5=jarValidation,testRuntimeClasspath Review Comment: This lock now resolves `joou-java-6:0.9.5`, but the license update only adds `joou-java-6-0.9.4.jar.sha1`. `validateJarChecksums` requires a version-specific checksum for every resolved JAR, so the license validation will fail until `solr/licenses/joou-java-6-0.9.5.jar.sha1` is generated (for example via `./gradlew updateLicenses`). ########## changelog/unreleased/PR#3119-update-org-apache-calcite.yml: ########## @@ -0,0 +1,8 @@ +title: Update org.apache.calcite to 1.28.0 Review Comment: The changelog reports Calcite 1.28.0, but this PR sets Calcite core/linq4j to 1.42.0; 1.28.0 is the Avatica version. Please name both versions so release notes accurately describe the dependency update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
