jaykay12 commented on code in PR #4610:
URL: https://github.com/apache/solr/pull/4610#discussion_r3825834624
##########
solr/cross-dc-manager/build.gradle:
##########
@@ -65,35 +62,23 @@ dependencies {
testRuntimeOnly libs.bytebuddy
testRuntimeOnly libs.bytebuddy.agent
+ testImplementation libs.testcontainers.kafka
+
testImplementation(libs.apache.kafka.streams) {
artifact {
classifier = "test"
}
}
- // EmbeddedKafkaCluster loads org.apache.kafka.test.TestCondition from this
at runtime
- testRuntimeOnly(libs.apache.kafka.clients) {
- artifact {
- classifier = "test"
- }
- }
- testRuntimeOnly(libs.apache.kafka.kafka213) {
- artifact {
- classifier = "test"
- }
- }
- testRuntimeOnly(libs.apache.kafka.server.common) {
- artifact {
- classifier = "test"
- }
- }
}
ext {
mainClass = 'org.apache.solr.crossdc.manager.consumer.Consumer'
- // Use of the security manager is not supported on windows.
- // Mockito does not work with it enabled.
- useSecurityManager = !Os.isFamily(Os.FAMILY_WINDOWS)
+ // Docker/Testcontainers integration tests (KafkaContainerRule) do PATH
scanning,
+ // spawn processes, and talk to the Docker daemon over a Unix socket -- none
of
+ // which play well with a static SecurityManager policy. Same rationale as
+ // solr:modules:extraction, Solr's other Testcontainers consumer.
+ useSecurityManager = false
Review Comment:
this is great! 💯
verified this working fine on local here:
https://github.com/apache/solr/pull/4610#discussion_r3825811842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
