epugh commented on code in PR #4738:
URL: https://github.com/apache/solr/pull/4738#discussion_r3829487348
##########
solr/webapp/src/test/org/apache/solr/webapp/AdminUiTestBase.java:
##########
@@ -127,32 +127,53 @@ public abstract class AdminUiTestBase extends
SolrCloudTestCase {
protected static JettySolrRunner standaloneJetty;
/**
- * Serves a minimal stand-in for the generated js-client bundle ({@code
libs/solr/index.js}),
- * which only exists inside the built webapp, not in the source tree tests
serve from. The
- * AngularJS {@code CollectionsV2} service fails to instantiate without the
{@code solrApi}
- * global, taking the whole Collections screen down with it. Only the small
API surface the
- * AngularJS UI actually uses is stubbed.
+ * Serves the js-client bundle the AngularJS UI expects at {@code
libs/solr/index.js}: its {@code
+ * CollectionsV2} service fails to instantiate without the {@code solrApi}
global, taking the
+ * whole Collections screen down with it. The real bundle is built by {@code
+ * :solr:webapp:js-client} and its location handed to the test JVM in {@code
+ * tests.ui.jsclient.bundle}; when that build is disabled ({@code
-PdisableJsClient=true}) the
+ * stub below is served instead, covering the only call the AngularJS UI
makes.
Review Comment:
I don't think this is really worth it.. We're about to land a bunch more V2
api calls in the Admin UI... So then we are stubbing more and more... This
type of complexity in our build processes is waht gets us flaky builds and
werid behaivors....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
