serhiy-bzhezytskyy opened a new pull request, #4779: URL: https://github.com/apache/solr/pull/4779
https://issues.apache.org/jira/browse/SOLR-18109 Moves the four deprecated `SolrPluginUtils` debug methods to `DebugComponent` -- resolves the file's own TODO: "resolve duplicated code with DebugComponent. Perhaps it should be added to doStandardDebug?" They were `@Deprecated // move to DebugComponent` since SOLR-17561 but never actually moved. Per Eric's comments on the ticket, included all four together (`doStandardDebug`, `doStandardQueryDebug`, `doStandardResultsDebug`, `doSimpleQuery`), not just the first one. Only 3 external call sites: 2 already in `DebugComponent` itself (now local calls, no prefix needed), 1 in `MoreLikeThisHandler` (updated, TODO removed). Widened `SolrPluginUtils.explanationsToStrings` from `private` to `public` -- the one cross-package dependency the move needed, since it isn't itself deprecated and stays a general-purpose utility in `SolrPluginUtils`. 26 tests, 0 failures (DebugComponentTest, DistributedDebugComponentTest, MoreLikeThisHandlerTest, MoreLikeThisComponentTest, SolrPluginUtilsTest). AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
