janhoy commented on code in PR #4738:
URL: https://github.com/apache/solr/pull/4738#discussion_r3831204904
##########
solr/webapp/src/test/org/apache/solr/webapp/AdminUiTestBase.java:
##########
@@ -492,8 +523,8 @@ protected static void assertNoSevereConsoleErrors(String...
allowedSubstrings) {
/** Locates a Chrome/Chromium binary, or returns null if none can be found.
*/
@SuppressForbidden(reason = "Reading CHROME_BIN/PATH from the environment to
locate a browser")
protected static Path findChromeBinary() {
- String sysProp = EnvUtils.getProperty("tests.ui.chrome.binary");
- if (sysProp != null) {
+ String sysProp = EnvUtils.getProperty("tests.selenium.chrome.binary");
+ if (sysProp != null && !sysProp.isBlank()) {
Review Comment:
Yea, let's keep this in mind, feel free to open a JIRA for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
