serhiy-bzhezytskyy opened a new pull request, #4788: URL: https://github.com/apache/solr/pull/4788
https://issues.apache.org/jira/browse/SOLR-18355 The ticket asked "we need to decide whether a modern spatial field type replaces this functionality or whether it can simply be dropped" before removing `geohash(lat,lon)` and `ghhsin(geohash1,geohash2,radius)` (deprecated, bare `@Deprecated`, no stated reason, since 9.0 via SOLR-13138). Checked before removing: - Zero test coverage anywhere in the tree for either function query. - Zero mentions in the reference guide docs. - Zero other in-tree callers besides the `ValueSourceParser` registration itself. - `HaversineFunction` (registered as `hsin`) already computes the same distance directly from raw lat/lon value sources, without needing to round-trip through a geohash-encoded string first. Removed `GeohashFunction`/`GeohashHaversineFunction`, their 2 `ValueSourceParser.addParser` registrations, and the now-unused imports. Changelog added (`type: removed`). Tests: `TestFunctionQuery`, `ExpressionValueSourceParserTest` green. cc @dsmiley (deprecated it, SOLR-13138) AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
