iprithv commented on code in PR #4775: URL: https://github.com/apache/solr/pull/4775#discussion_r3832096549
########## solr/api/src/java/org/apache/solr/client/api/endpoint/NodePropertiesApi.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.client.api.endpoint; + +import io.swagger.v3.oas.annotations.Operation; +import io.swagger.v3.oas.annotations.Parameter; +import jakarta.ws.rs.GET; +import jakarta.ws.rs.Path; +import jakarta.ws.rs.QueryParam; +import org.apache.solr.client.api.model.NodePropertiesResponse; + +/** V2 API definition for listing JRE system properties on a Solr node. */ +@Path("/node/properties") +public interface NodePropertiesApi { + + @GET + @Operation( + summary = "List system properties for the target Solr node.", + tags = {"node"}) + NodePropertiesResponse getNodeProperties( + @Parameter(description = "Optional name of a single system property to return.") + @QueryParam("name") Review Comment: yes, other v2 property APIs already put the name in the path (/cluster/properties/{propertyName}, /collections/{coll}/properties/{propName}), and SOLR-15781 is specifically about making v2 more REST-ful. switched the v2 single-property form to GET /api/node/properties/{propertyName}. dotted JRE names like java.version are a single path segment, so they work the same way as the other property APIs. :) also added a Ref Guide note on implicit-requesthandlers (and a pointer from the Java Properties screen) covering list vs single-property and v1 vs v2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
