serhiy-bzhezytskyy opened a new pull request, #4789: URL: https://github.com/apache/solr/pull/4789
## What Removes the deprecated 2-arg `DocsStreamer.convertLuceneDocToSolrDoc(Document, IndexSchema)` overload. Deprecated since SOLR-11891 (2018-03-19, Chris Hostetter) in favor of the 3-arg `convertLuceneDocToSolrDoc(Document, IndexSchema, ReturnFields)` version, which is also more efficient (avoids converting fields that aren't needed). ## Verification performed before removing - Grepped every call site of `convertLuceneDocToSolrDoc` in the tree: both production callers (`TextResponseWriter`, `SolrDocumentFetcher`) and the one test file exercising it (`ReturnFieldsTest`, via a static import of the method name) already call the 3-arg version. - Zero callers of the 2-arg overload anywhere in the repo. - Full-repo `./gradlew compileTestJava` (exit 0) confirms no remaining references, not just in the modules touched. - `ReturnFieldsTest` green. ## Changelog `DocsStreamer` is part of `solr-core` (a published Maven artifact) and this was a `public static` method, so a `type: removed` changelog entry is included. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
