[
https://issues.apache.org/jira/browse/SOLR-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106751#comment-18106751
]
Jason Gerlowski commented on SOLR-18332:
----------------------------------------
All of the commits on this ticket so far have been removing usages in our
tests. That was the easiest, lowest-hanging fruit and it's made a pretty
significant dent in the usage. By my rough count (see below for command) we've
dropped the usages in half from ~1600 down to ~800.
{code}
$ git grep -iI "qt" | grep -iv qtime | grep -iv changelog | grep -v words.txt |
grep -iv QType | wc -l
829
{code}
The next big chunk of usages to tackle is our streaming code (esp. SolrStream),
where 'qt' is used pretty ubiquitously and could be removed without too much
trouble by giving SolrStream a constructor param. After that the usages get a
bit thornier, and snags are more likely...
> Remove usages of deprecated 'qt' parameter and related SolrJ functionality
> --------------------------------------------------------------------------
>
> Key: SOLR-18332
> URL: https://issues.apache.org/jira/browse/SOLR-18332
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Affects Versions: main(11.0)
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> SOLR-17715 deprecated SolrQuery's setRequestHandler/getRequestHandler methods
> in favor of a new QueryRequest ctor that takes an explicit requestHandler.
> SolrJ users no longer need to send 'qt' to select a handler.
> There's some debate over whether this deprecation will "stick" and whether
> we'll be able to eliminate all usages of qt, but in the meantime there are
> many usages of 'qt' (and related methods) that are inarguably unnecessary.
> This ticket tracks incrementally removing usages of the deprecated SolrJ
> convenience methods / 'qt'-as-handler-override pattern in the codebase, in
> cases where a path-based alternative exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
