serhiy-bzhezytskyy commented on PR #4781: URL: https://github.com/apache/solr/pull/4781#issuecomment-5379899463
`testMaxFutureMs` passing isn't evidence toward removing the class-level `@AwaitsFix` -- it's unrelated to what SOLR-13059 tracks. The base class's own comment says the underlying race historically failed ~0.3% of the time (500x20 threads) and is currently masked by a `Thread.sleep(500)` workaround, not fixed. I ran `testSliceRouting` 100x clean, but that's weak evidence for a 0.3% flake rate (~26% chance of catching it in 100 runs). I'd leave the annotation as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
