serhiy-bzhezytskyy commented on PR #4787: URL: https://github.com/apache/solr/pull/4787#issuecomment-5379971179
`ErrorLogMuter` is a plain `Closeable`, not enforced try-with-resources -- you can do `var muter = ErrorLogMuter.regex(...); ...; muter.close();` for the exact old ignore/un-ignore statement-pair feel, no nesting needed. Trade-off is losing the auto-cleanup-on-exception guarantee try-with-resources gives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
