dweiss commented on PR #4793: URL: https://github.com/apache/solr/pull/4793#issuecomment-5381807733
It looks ok to me, @janhoy . The "style" this is implemented in aligns with what it was before - I'm not sure it's a good one (yes, I authored it a long time ago but gradle... has changed a lot since then). In Lucene/main, this validation has been rewritten from scratch based on newer APIs. I can't really tell if it's "better" and I can't really tell if it's useful here - maybe a prompt to claude to compare this against Lucene's implementation would bring some clarity of what can be improved. https://github.com/apache/lucene/blob/main/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/licenses/CheckJarChecksumsAndLicensesPlugin.java I'm sorry - I don't feel like I've helped out much here... I'm sure all of it can be improved, especially if rethought from scratch like that design doc David pointed to does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
