serhiy-bzhezytskyy commented on PR #4783: URL: https://github.com/apache/solr/pull/4783#issuecomment-5394692158
You're right that #3684 is the prior work, and I should have looked at it more closely before opening this. I have now. The CI failure you flagged was real: the client hardcoded `waitForFinalState=true` and always sent it, breaking `CollectionAdminRequestRequiredParamsTest`. Root cause, not surface-level -- fixed by removing the client-side param entirely rather than editing the test. I also went back to your comment on #3684 (`I'd be more comfortable making this change now if there's a global flag... to mitigate the performance/scale risk`) and implemented exactly that: `-Dsolr.cloud.waitForFinalState.enabled`, resolved server-side. One addition past what #3684 proposed: the default itself now differs by command. `BALANCE_REPLICAS`/`MIGRATE_REPLICAS`/`REPLACENODE` keep the old `false` default -- their wait is unbounded (scales with however many replicas move, one timeout regardless of count), unlike `ADDREPLICA`/`MOVEREPLICA`'s fixed-size wait. The flag still overrides all 8 either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
