epugh commented on PR #4769: URL: https://github.com/apache/solr/pull/4769#issuecomment-5399016226
> Checked all three: > > * `fromNode` is a public REST param for MOVEREPLICA (read directly from the request in `MoveReplicaCmd`), not internal-only. > * MoveReplica isn't exposed in either the classic or the new experimental Admin UI (checked both, zero hits) -- no UI code to update. > * There's precedent for exactly this: `major-changes-in-solr-10.adoc` has a "Deprecation Code Removals" section listing single-param/field-type removals of similar or smaller scope (`EnumField`, `CurrencyField`, `addHttpRequestToContext`). > > Given that, this whole batch is probably under-documented -- going through the other tickets, at least 9-11 more removals look similarly upgrade-notes-worthy (`CloudSolrClient.connect()`/the legacy Builder in particular -- likely the biggest compile-break in the batch). Before I add a "Deprecation Code Removals" section to `major-changes-in-solr-11.adoc` covering the whole batch, @dsmiley @epugh -- does that match what you'd want documented, or is there a narrower bar you'd prefer (e.g. skip aliases like `PROPERTY_PREFIX` that never had real behavior of their own)? > > AI-assisted (Claude Sonnet 5) I think I've come around to this is small enough chagne from a public perspective, we don't need to sweat it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
