serhiy-bzhezytskyy commented on PR #4777: URL: https://github.com/apache/solr/pull/4777#issuecomment-5394907844
Inline comment (`BackupManager.java`): you're right -- `Utils.fromJSON` already returns `Map.of()` for a zero-length array, so the ternary duplicated that check. Removed it, just calls `Utils.fromJSON(arr, 0, arr.length)` directly now. SOLR-16328 vestiges: already done -- grepped the whole tree for `STR_INTERNER_OBJ_BUILDER`, `WeakStringInterner`, `setStrInternerParser`, any config/doc reference: zero hits anywhere. My earlier commit (removing `createFromJson` + `CoreContainer.setWeakStringInterner()` + `ClusterState.setStrInternerParser()`) already covered it -- landed before your research comment, for the same reason you found: the interner never reached the real ZK hot path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
