gerlowskija commented on code in PR #4799:
URL: https://github.com/apache/solr/pull/4799#discussion_r3855555735
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SolrStream.java:
##########
@@ -64,34 +65,33 @@ public class SolrStream extends TupleStream {
private boolean distrib = true;
private String user;
private String password;
- private String core;
private transient SolrClientCache clientCache;
private transient boolean doCloseCache;
// TODO SOLR-17995 proposes that we should deprecate this constructor in
favor of one of the other
// constructors that requires users to provide the core as an explicit
parameter
/**
- * @param baseUrl URL of the Solr core or collection to query, typically of
the form
+ * @param collectionOrCoreUrl URL of the Solr core or collection to query,
typically of the form
* "http://host:8983/solr/myCore";.
* @param params query-parameters sent with the streaming request
*/
- public SolrStream(String baseUrl, SolrParams params) {
- this.baseUrl = baseUrl;
+ public SolrStream(String collectionOrCoreUrl, SolrParams params) {
+ this.baseUrl = collectionOrCoreUrl;
Review Comment:
I'd rather not:
1. Folks sometimes deploy Solr behind a proxy at a path of their choosing.
Since SolrStream is a client-side class, I think we need to be flexible to
accommodate that.
2. It'd bake in v1 API specific assumptions.
3. I'm hoping to get to SOLR-17995 pretty quickly and deprecate/remove this
ctor altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
