serhiy-bzhezytskyy commented on code in PR #4808: URL: https://github.com/apache/solr/pull/4808#discussion_r3860232737
########## solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc: ########## @@ -1620,9 +1620,8 @@ Multiple collections cannot be backed up to the same location. [NOTE] ==== -Previous versions of Solr supported a different backup file format that lacked the incremental support described above. -Solr can still restore from backups that use this old format, but creating new backups of this format is not recommended and is officially deprecated. -See the `incremental` parameter below for more information. +Previous versions of Solr supported creating a different, non-incremental backup file format that lacked the incremental support described above. +That format can no longer be created, but Solr can still restore from backups that already use it. Review Comment: No stated removal plan for restore-support -- `RestoreCmd.java` still branches on `incremental` with no deprecation marker on that path, and the JIRA only scopes removing the create-path. ########## solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc: ########## @@ -1647,7 +1646,7 @@ s|Required |Default: none What to name the backup that is created. Provided as a query parameter for v1 requests, or as a path segment for v2 requests. + -For incremental backups, the backup name should be reused to add new backup points to the existing backup. For non-incremental backups (deprecated), this name is checked to ensure it doesn't already exist, and an error message is raised if it does. +The backup name should be reused to add new backup points to the existing backup. Review Comment: Rephrased, and clarified the create-vs-add-point behavior it was glossing over -- see the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
