NextbrickInc opened a new pull request, #4817: URL: https://github.com/apache/solr/pull/4817
https://issues.apache.org/jira/browse/SOLR-18350 # Description `SolrCore#getLatestSchema()` may change during request processing. This patch replaces callers that already have a `SolrQueryRequest` or `SolrIndexSearcher` in scope with the corresponding stable schema accessor. # Solution - Use `SolrQueryRequest#getSchema()` for request-scoped schema lookups. - Use `SolrIndexSearcher#getSchema()` when interpreting data associated with a searcher. - Document these alternatives on `SolrCore#getLatestSchema()`. - Leave schema mutation, lifecycle, initialization, managed-resource, and other genuinely live-schema paths unchanged. - Update the affected Mockito request fixture. This patch was developed with assistance from OpenAI Codex. The resulting changes were reviewed and tested locally by the contributor. # Tests - 181 focused Solr core tests passed. - 88 language-model tests passed. - `./gradlew tidy` passed. - Affected-module checks passed. - `git diff --check` passed. A whole-repository check was attempted, but the documentation/Antora portion was blocked by a local path-with-spaces environment issue. The affected code-module checks passed. # Checklist - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers access to contribute to my PR branch. - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the Reference Guide. - [ ] I have added a changelog entry for my change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
