NextbrickInc commented on PR #4774: URL: https://github.com/apache/solr/pull/4774#issuecomment-5465542077
@HoustonPutman — following up on your two comments, since my reply was inline and easy to miss. Both are addressed in 21cb72bc75: OnDisconnect and OnReconnect are reverted to their original form — no interface or semantic change in the shared adapters. ZkController and the standalone ZkStateReader each own a private AtomicBoolean, set only when Curator reports LOST. The reconnect handler uses compareAndSet(true, false), so SUSPENDED → RECONNECTED does not run recovery, while LOST → RECONNECTED runs it once and consumes the flag. That keeps the state local to the two classes that need it and removable in one place when persistent watchers make this path unnecessary. Tests: the two listener-contract tests plus a three-node integration test separating ensemble failover from injected session expiry. gradlew check is green. Please approve , merge code. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
