epugh opened a new pull request, #4840:
URL: https://github.com/apache/solr/pull/4840
# Description
Split out from #4743 into smaller, per-module PRs to make review easier.
This PR contains the tidy-up changes to `solr/modules/sql` (Calcite/JDBC
integration).
# Solution
Leverage IntelliJ warnings (`StringBuilder` conversions in `SolrFilter`'s
AND/OR translation, `.get(0)` → `.getFirst()`, dead-code removal,
javadoc/comment fixes). The `SolrFilter`/`SolrAggregate`/`SolrEnumerator`
predicate-translation logic was checked to confirm AND/OR/NOT semantics are
unchanged.
**Includes a restored fix:** two `@SuppressWarnings("resource")` annotations
on `ParallelStream` declarations in `SolrTable.java` that had been dropped by
the original tidy pass. `ParallelStream` is `Closeable`, but ownership
transfers to the caller's stream chain rather than being closed locally in this
method, so the annotation legitimately suppresses a false-positive
resource-leak warning.
# Tests
existing
Relates to #4743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
