adamjq commented on code in PR #4698:
URL: https://github.com/apache/solr/pull/4698#discussion_r3898354730
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -499,6 +499,16 @@ public ValueSource getValueSource(SchemaField field,
QParser parser) {
SolrException.ErrorCode.BAD_REQUEST, "Vector encoding not supported
for function queries.");
}
+ /** Throws if this field type does not support KNN vector queries. */
Review Comment:
Thanks, will do that going forward
In this case, I thought this was needed to support
ScalarQuantizedDenseVectorFields with the query parsers while DenseVectorField
with a flat index still doesn't. Ideally, the check could be removed if we add
support for KNN query parser for DenseVectorField with `knnAlgorithm=flat`.
This works natively for the `Lucene104ScalarQuantizedVectorsFormat` as it
has a [Lucene104ScalarQuantizedVectorsReader
implementation](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsFormat.java#L135)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
