zhangxinyao88 opened a new pull request, #4861: URL: https://github.com/apache/solr/pull/4861
https://issues.apache.org/jira/browse/SOLR-18343 # Description SolrJ's multi-action admin request classes currently default to GET, including requests that modify server state. # Solution This adds constructors that require an HTTP method and updates the Collection, Core, and ConfigSet admin requests to choose GET or POST explicitly. The existing GET-defaulting constructors remain available but are deprecated for compatibility. Read-only requests use GET. Other admin actions use POST. I used an AI coding assistant to audit the constructor call sites, make the mechanical edits, and run validation. I reviewed the final diff and the method chosen for each action. # Tests - `./gradlew tidy` - Focused SolrJ tests: 21 tests passed - `:solr:core:ecjLintTest` - `:solr:solrj:check` The full `./gradlew check -x test` reached the Antora documentation build, which failed because the local checkout path contains spaces. # Checklist - [x] I have reviewed the contribution guidelines. - [x] I have added the Jira issue ID to the PR title. - [x] I developed the patch against `main`. - [x] I added tests for the changes. - [ ] I have run the complete `./gradlew check`. - [ ] I added Reference Guide documentation. Not needed for this SolrJ API change. - [ ] I added a changelog entry. Not added while the Jira issue is unassigned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
