epugh commented on code in PR #4831:
URL: https://github.com/apache/solr/pull/4831#discussion_r3907324303
##########
solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/consumer/PartitionManager.java:
##########
@@ -41,16 +39,52 @@ public class PartitionManager {
new ConcurrentHashMap<>();
private final KafkaConsumer<String, MirroredSolrRequest<?>> consumer;
- static class PartitionWork {
+ @VisibleForTesting
+ public static class PartitionWork {
Review Comment:
Yeah, I mean, the more I looked, the more it seemed like you did what was
the right path, and what Kafka recommends. Thanks! Kafka is all new to me
;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
