[ 
https://issues.apache.org/jira/browse/SOLR-18414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris M. Hostetter updated SOLR-18414:
--------------------------------------
    Attachment: SOLR-18414.patch
        Status: Open  (was: Open)

Here is a quickly hacked up patch I made against {{branch_10x}} (that also 
applies fairly easily to 10.0.0 ) to force the QueryLimits codepath for every 
request.

 

On 10x it results in only 2 test failures..

 
{noformat}
  2> NOTE: reproduce with: gradlew test --tests 
TestRangeQuery.testRangeQueryWithFilterCache -Dtests.seed=801D605A17EEE9FB 
-Dtests.locale=bs-Cyrl-BA -Dtests.timezone=America/Cayenne -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestLTRQParserPlugin.ltr_expensiveFeatureRescoringAndPartialResultsNotTolerated_shouldRaiseException
 -Dtests.seed=801D605A17EEE9FB -Dtests.locale=en 
-Dtests.timezone=Asia/Famagusta -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8{noformat}
 

On 10.0.0 it triggers 55 test failures...

 
{noformat}
  2> NOTE: reproduce with: gradlew test --tests 
TestFunctionQuery.testTFIDFFunctions -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=nd-Latn-ZW -Dtests.timezone=America/Cambridge_Bay 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestFunctionQuery.testOrdAndRordOverPointsField -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=nd-Latn-ZW -Dtests.timezone=America/Cambridge_Bay 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
QueryElevationComponentTest.testTrieFieldType -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=ksb-TZ -Dtests.timezone=Asia/Yangon -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests CloudMLTQParserTest.testBoost 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=bs-BA -Dtests.timezone=Universal 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
CloudMLTQParserTest.testUnstoredAndUnanalyzedFieldsAreIgnored 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=bs-BA -Dtests.timezone=Universal 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
CloudMLTQParserTest.testMLTQParser -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=bs-BA -Dtests.timezone=Universal -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestSortByMinMaxFunction.test 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=ce-RU 
-Dtests.timezone=Europe/Athens -Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestJoin.testRandomJoin 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=mt-MT 
-Dtests.timezone=Africa/Ndjamena -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestJoin.testIndexJoin 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=mt-MT 
-Dtests.timezone=Africa/Ndjamena -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestJoin.testTopLevelDVJoin 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=mt-MT 
-Dtests.timezone=Africa/Ndjamena -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestJoin.testJoinAllMethods 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=mt-MT 
-Dtests.timezone=Africa/Ndjamena -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestDistribIDF.testSimpleQuery 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=ha 
-Dtests.timezone=America/Mexico_City -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestDistribIDF.testMultiCollectionQuery -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=ha -Dtests.timezone=America/Mexico_City -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestExactStatsCacheCloud.testBasicStats -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=tg-Cyrl-TJ -Dtests.timezone=Africa/Bujumbura 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestLRUStatsCacheCloud.testBasicStats -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=en-AT -Dtests.timezone=America/Belem -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests ShardJoinRouterTest.testNoScore 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=kok 
-Dtests.timezone=Africa/Nouakchott -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
CrossCollectionJoinQueryTest.testCcJoinRoutedCollection 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=nus-SS -Dtests.timezone=Egypt 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
CrossCollectionJoinQueryTest.testAllowSolrUrlsList 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=nus-SS -Dtests.timezone=Egypt 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
CrossCollectionJoinQueryTest.testCcJoinNonroutedCollection 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=nus-SS -Dtests.timezone=Egypt 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestExactStatsCache.test 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=en-BI 
-Dtests.timezone=America/Belize -Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
DistribJoinFromCollectionTest.testNoScore -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=ksf -Dtests.timezone=Asia/Yakutsk -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestJsonRequest.testLocalJsonRequest -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=ar-LY -Dtests.timezone=Turkey -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestExactSharedStatsCache.test 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=su-Latn 
-Dtests.timezone=Europe/Rome -Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestSubQueryTransformer.testRowsStartForSubqueryAndScores 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=fr-TG 
-Dtests.timezone=Atlantic/Madeira -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestCrossCoreJoin.testJoin 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=bem-ZM -Dtests.timezone=US/Central 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
ShardJoinImplicitTest.testNoScore -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=ff-Latn-GW -Dtests.timezone=Africa/Johannesburg 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
ShardJoinImplicitTest.testNoScoreFailOnFieldCheck -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=ff-Latn-GW -Dtests.timezone=Africa/Johannesburg 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestExactSharedStatsCacheCloud.testBasicStats -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=tzm-Latn-MA -Dtests.timezone=Pacific/Niue -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests SortByFunctionTest.test 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=es-419 
-Dtests.timezone=America/Indiana/Knox -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestFiltersQueryCaching.testRecursiveFilter -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=en -Dtests.timezone=America/Goose_Bay -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestCloudJSONFacetJoinDomain.testBespoke -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=sr-CS -Dtests.timezone=Asia/Tbilisi -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestCloudJSONFacetJoinDomain.testRandom -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=sr-CS -Dtests.timezone=Asia/Tbilisi -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestCloudJSONFacetJoinDomain.testJoinMethodSyntax -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=sr-CS -Dtests.timezone=Asia/Tbilisi -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestLRUStatsCache.test 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=ff-Latn-CM 
-Dtests.timezone=Europe/Monaco -Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestSolrQueryParser.testFilter 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=ff-Latn-CM 
-Dtests.timezone=Asia/Calcutta -Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestSolrQueryParser.testLocalParamsInQP -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=ff-Latn-CM -Dtests.timezone=Asia/Calcutta -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
SimpleMLTContentQParserTest.doTest -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=mfe -Dtests.timezone=Europe/Athens -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
SolrIndexSearcherTest.testReranking -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=en-PR -Dtests.timezone=America/Argentina/San_Luis 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests GraphQueryTest.testGraph 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=sc -Dtests.timezone=Asia/Aqtobe 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
ShardJoinCompositeTest.testNoScore -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=sv-Latn-SE -Dtests.timezone=US/Aleutian -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
InvalidConfigJoinQueryTest.testInvalidFilterConfig 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=ka 
-Dtests.timezone=America/Menominee -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestJsonFacetRefinement.testBasicRefinement -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=nn-Latn-NO -Dtests.timezone=America/Thule -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
ConvertedLegacyTest.testABunchOfConvertedStuff -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=pcm -Dtests.timezone=Africa/Bangui -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestRangeQuery.testRangeQueryWithFilterCache -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=zh -Dtests.timezone=America/Shiprock -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestSolr4Spatial2.testRptWithGeometryGeo3dField -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=nyn-Latn-UG -Dtests.timezone=Etc/UCT -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestJsonFacets.testNestedJoinDomain -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=es-BZ -Dtests.timezone=America/Argentina/Tucuman 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests TestJsonFacets.testDomainGraph 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=es-BZ 
-Dtests.timezone=America/Argentina/Tucuman -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestJsonFacets.testDomainJoinSelf -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=es-BZ -Dtests.timezone=America/Argentina/Tucuman 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestJsonFacets.testQueryJoinBooksAndPages -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=es-BZ -Dtests.timezone=America/Argentina/Tucuman 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
CloudMLTQContentParserTest.testUnstoredAndUnanalyzedFieldsAreIgnored 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=chr-Cher-US 
-Dtests.timezone=America/Havana -Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
CloudMLTQContentParserTest.testBoost -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=chr-Cher-US -Dtests.timezone=America/Havana -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
CloudMLTQContentParserTest.testMLTQParser -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=chr-Cher-US -Dtests.timezone=America/Havana -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests SimpleMLTQParserTest.doTest 
-Dtests.seed=385461E230BF1EC1 -Dtests.locale=en-MW -Dtests.timezone=Etc/GMT-5 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestLocalStatsCacheCloud.testBasicStats -Dtests.seed=385461E230BF1EC1 
-Dtests.locale=bs-Cyrl -Dtests.timezone=Europe/Vienna -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
  2> NOTE: reproduce with: gradlew test --tests 
TestLTRQParserPlugin.ltr_expensiveFeatureRescoringAndPartialResultsNotTolerated_shouldRaiseException
 -Dtests.seed=385461E230BF1EC1 -Dtests.locale=uz-Arab -Dtests.timezone=Iceland 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
{noformat}
 

> Randomize use of QueryLimits in all tests 
> ------------------------------------------
>
>                 Key: SOLR-18414
>                 URL: https://issues.apache.org/jira/browse/SOLR-18414
>             Project: Solr
>          Issue Type: Task
>            Reporter: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-18414.patch
>
>
> This is a suggesting Smiley made in SOLR-18156...
> {quote}Maybe our test randomization should sometimes {{rarely()}} use a super 
> long {{timeAllowed}} to help exercise this.
> {quote}
> Since TestInjection already has an easy way to add a QueryLimit, this can be 
> done fairly easily using a "dummy" impl



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to