zhangxinyao88 commented on code in PR #4870:
URL: https://github.com/apache/solr/pull/4870#discussion_r3930762120
##########
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##########
@@ -201,8 +201,12 @@ public SolrCore getCore() {
return core;
}
+ /**
+ * If the request has been created, return its parameters (merges URL and
body if applicable);
+ * otherwise, return only the URL query parameters.
+ */
public SolrParams getQueryParams() {
Review Comment:
One thing to check: this also changes the V2 tracing golden output.
`TestDistributedTracing.testV2Api` currently expects four `post:/admin/cores`
spans, but reading the parsed POST params changes those to
`reload:/admin/cores`. Could we update the golden file or add coverage here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
