serhiy-bzhezytskyy opened a new pull request, #78:
URL: https://github.com/apache/solr-orbit/pull/78

   ### Description
   
   `convert-workload` copies operation names through, so a converted workload 
keeps OpenSearch's word for an aggregation — `date_histogram_agg`, 
`country_agg_cached`. The workloads in solr-orbit-workloads use the facet 
names, so these are the only names a regeneration does not reproduce.
   
   An operation name is also what a test procedure schedules, the prefix of its 
`<name>_iterations` parameters, and the key `workload.py` registers a value 
source under, so the rename covers all of them — renaming only the definition 
gives a workload that loads and then aborts with a missing value source. The 
token is matched on its own, so `aggs` and `aggregation` are untouched. Each 
rename is recorded in `CONVERTED.md`.
   
   ### Issues Resolved
   
   None.
   
   ### Testing
   
   - [x] New functionality includes testing
   
   Unit tests for the token boundaries, all four reference sites and an 
end-to-end conversion. Regenerating nyc_taxis and geonames now produces every 
operation name the shipped workloads use, and the only lines that change in the 
generated output are the names themselves.
   
   ---
   By submitting this pull request, I confirm that my contribution is made 
under the terms of the Apache 2.0 license.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to