tballison commented on code in PR #4853:
URL: https://github.com/apache/solr/pull/4853#discussion_r3937529283


##########
solr/modules/extraction/src/test-files/extraction/tika-server-config.json:
##########
@@ -0,0 +1,5 @@
+{
+  "server": {
+    "allowPerRequestConfig": true

Review Comment:
   Be careful with the security implications of this. This means that a user 
can configure parsers and timeouts and other security related items. I don't 
think the attack path exists anymore but command injection via per request 
config was on the table at some point during our pre 4.0.0-alpha-1 development.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to