chan-dx commented on code in PR #4829: URL: https://github.com/apache/solr/pull/4829#discussion_r3944496220
########## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ########## @@ -103,6 +103,12 @@ Its builder will dynamically detect if solr-jetty is available and use that, oth CommonParams.QT has been un-deprecated. Nonetheless, if your code makes explicit reference to "qt" when constructing a standard request, there is usually a better way. +`CloudSolrClient` now retries a failed update only when the transport can prove the request never reached the server. +Previously any communication error, or a 503, caused a retry, which could re-send an update that had already been partially applied. + +`SolrClient` gains `wasRequestUnsent(Throwable)` and `wasCommError(Throwable)`, both defaulting to `false` and overridden per transport. Review Comment: Done, removed the ref guide update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
