janhoy commented on PR #4803: URL: https://github.com/apache/solr/pull/4803#issuecomment-5581142875
The 510 code used by v2 looks a bit off, although I understand the intent behind it, it is better than a 503 which could signal that the entire Solr node is unavailable. Prometheus scraping an endpoint will interpret any non-200 code as "solr scrape target unavailable" and flag it as `DOWN`. A 200-code with empty response will be interpreted as "solr scrape target functioning, but no data" and flag it as "UP". You can argue both ways. But agree v1 and v2 shuold probably be aligned. I'm not opposed to instead align v1 with HTTP 510 and adapt frontend to detect this as a "metrics disabled" signal instead of text parsing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
