epugh commented on PR #4812: URL: https://github.com/apache/solr/pull/4812#issuecomment-5601171193
> All three are right -- I checked each against the code, not the description. Taking the patch as it stands. > > On compute-once: yes, and two things it also buys. The peek re-analyses the whole query to learn one boolean, which `!tokens.isEmpty()` answers. And the swallowed `IOException` stops being a separate decision -- the old per-word `catch` around `analyze()` is only restorable once the tokens exist as a list. I'd do that as its own change. Are you thinking "as its own change" in this PR, or as a follow on PR? If it's a follow on PR, want to try the "stacked PR's" feature of github? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
