Copilot commented on code in PR #4650: URL: https://github.com/apache/solr/pull/4650#discussion_r3965513281
########## ui/build.gradle.kts: ########## @@ -0,0 +1,59 @@ +import com.diffplug.gradle.spotless.SpotlessExtension + +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + Review Comment: The ASF license header should be the first content in the file; currently an import precedes it. ########## solr/webapp/build.gradle: ########## @@ -50,10 +52,7 @@ dependencies { if (gradle.ext.withJsClient) { generatedJSClientBundle project(path: ":solr:webapp:js-client", configuration: "jsClientBundle") } - - if (gradle.ext.withUiModule) { - generatedUIBundle project(path: ":solr:ui", configuration: "wasmJsUIBundle") - } + uiBundle project(path: ":solr:webapp", configuration: "wasmJsUIBundle") Review Comment: This declares a dependency on the same project (":solr:webapp"), which Gradle treats as a self-dependency and can fail resolution; it’s also unnecessary since the UI bundle is produced by tasks in this project. ########## .github/workflows/new-ui-check.yml: ########## @@ -0,0 +1,43 @@ +name: Solr UI Tests + +on: + pull_request: + branches: + - '*' + paths: + - 'new-ui-check.yml' Review Comment: The workflow path filter references 'new-ui-check.yml' at repo root, but the file lives under .github/workflows/, so edits to this workflow won’t trigger it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
