dsmiley commented on code in PR #4850: URL: https://github.com/apache/solr/pull/4850#discussion_r4002350141
########## solr/modules/jwt-auth/gradle.lockfile: ########## @@ -5,12 +5,11 @@ com.carrotsearch.randomizedtesting:randomizedtesting-runner:2.9.1=jarValidation,testCompileClasspath,testRuntimeClasspath com.carrotsearch:hppc:0.11.1=jarValidation,runtimeClasspath,runtimeLibs,solrPlatformLibs,testRuntimeClasspath com.fasterxml.jackson.core:jackson-annotations:2.22=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,solrPlatformLibs,testCompileClasspath,testRuntimeClasspath -com.fasterxml.jackson.core:jackson-core:2.22.2=jarValidation,runtimeClasspath,runtimeLibs,solrPlatformLibs,testCompileClasspath,testRuntimeClasspath -com.fasterxml.jackson.core:jackson-databind:2.22.2=jarValidation,runtimeClasspath,runtimeLibs,solrPlatformLibs,testCompileClasspath,testRuntimeClasspath +com.fasterxml.jackson.core:jackson-core:2.22.2=jarValidation,runtimeClasspath,runtimeLibs,solrPlatformLibs,testRuntimeClasspath Review Comment: Our lockfile shows this isn't a big deal as Eric's mailing list posed it might be. runtimeClasspath is still Jackson 2x ########## solr/modules/jwt-auth/gradle.lockfile: ########## @@ -207,4 +201,8 @@ org.slf4j:jcl-over-slf4j:2.0.18=jarValidation,runtimeClasspath,runtimeLibs,solrP org.slf4j:jul-to-slf4j:2.0.18=solrPlatformLibs org.slf4j:slf4j-api:2.0.18=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,solrPlatformLibs,testCompileClasspath,testRuntimeClasspath org.xerial.snappy:snappy-java:1.1.10.8=jarValidation,runtimeClasspath,runtimeLibs,solrPlatformLibs,testRuntimeClasspath +tools.jackson.core:jackson-core:3.2.1=jarValidation,testCompileClasspath,testRuntimeClasspath +tools.jackson.core:jackson-databind:3.2.1=jarValidation,testCompileClasspath,testRuntimeClasspath Review Comment: I see we have "tools.jackson.core" (whatever that is) on the test runtime classpath (as seen on this line), but `com.fasterxml.jackson.core:jackson-core:2.22.2` is also _still_ on the test runtime classpath. That's questionable... I guess if tests pass then it's only tests so whatever :shrug: ########## changelog/unreleased/PR#4850-update-okhttp-okio.yml: ########## Review Comment: IMO we should drop changelogs that "just" fiddle with dependencies and their versions -- as this does. Major dependencies or SolrJ would be an exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
