serhiy-bzhezytskyy commented on PR #4914: URL: https://github.com/apache/solr/pull/4914#issuecomment-5698017628
Checked every production use of InputStreamResponseParser for the same gap: - IndexFetcher and SolrStream already check responseStatus themselves. - JSONTupleStream.create(), SplitShardCmd (shard-split metrics), and NodeValueFetcher.fetchMetrics() don't check it at all — same bug, three more spots. - MetricsHandler's proxy path is unclear, not verified either way yet. Factored the check into a static checkHttpStatus(NamedList) on InputStreamResponseParser and used it at those three spots, then also at the original two — ApiTool and PackageUtils were duplicating the same inline check, this dedupes it while keeping the URL/body in the message: e47013d4057d8af2afebc1fbfb60aeccddd2736b, b2428990f713f70e7ea008d1e92120ebf83af421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
