mlbiscoc commented on PR #4907: URL: https://github.com/apache/solr/pull/4907#issuecomment-5796799985
Ok I updated the PR in the latest commit. Few changes: 1. I removed that incubator dependency you added. I don't think we need it with the OTEL upgrade and changing the JVM metrics to that merged runtime dependency. Tests pass locally without it. 2. I fixed the test proving it fixed the bug. It fails on main and passes after the fix. Now I need someone else to review my changes if they can and we can merge. Only thing is CI is failing too from changes unrelated to mine but look related to commit https://github.com/apache/solr/commit/e044bf20b405b8ca985730be3553d77d1fc8ff31 @dsmiley I think it broke tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
