nick-boss-tech opened a new pull request, #4939: URL: https://github.com/apache/solr/pull/4939
## Summary Failed merges could double-stop the OTEL merge timer. With assertions enabled, the second stop could replace the original merge exception with an `AssertionError` and prevent failed-merge metrics from being recorded correctly. This change makes `updateMergeMetrics` the sole owner of merge-timer completion. Success metrics are recorded only after `super.merge(...)` returns, so a metrics failure after a successful Lucene merge is not classified as a failed merge. ## Tests - `:solr:core:test --tests org.apache.solr.update.SolrIndexMetricsTest` JIRA: SOLR-18135 ## AI assistance OpenAI Codex assisted with research, implementation, and preparation of this contribution. The contributor reviewed the resulting diff and remains responsible for the final contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
