adityamparikh opened a new pull request, #237: URL: https://github.com/apache/solr-mcp/pull/237
## What Makes the Solr compatibility matrix pass on Solr 8.11 and 10 by having the affected integration tests assert what each Solr version actually does: - **Solr 10+** — `/admin/mbeans` was removed, and `CollectionService` degrades cache and handler stats to `null` (documented in AGENTS.md → *Solr 10 Compatibility*). `testGetCollectionStats_reflectsIndexedData`, `testGetCacheMetrics_afterQueries` and `testGetHandlerMetrics_afterQueriesAndIndexing` now assert that `null` on 10+ and keep their full assertions on 8.11/9.x. - **Solr < 9** — `DenseVectorField` arrived in 9.0, so `addFieldTypes_denseVectorField_schemaRoundTrip` now asserts the `RemoteSolrException` Solr 8.11 raises, and keeps the round trip on 9+. `TestcontainersConfiguration` gains `solrImage()` (the existing `solr.test.image` lookup, moved) and `solrMajorVersion()` (parsed from the image tag) so tests can branch on the server under test. ## Why `solr-compatibility` in `build-and-publish.yml` runs only on pushes to `main` (it is skipped on PRs), so these failures never surface in PR checks. It fails on every push to `main` — e.g. [run 35132047069](https://github.com/apache/solr-mcp/actions/runs/35132047069) for #199: *Solr 10-slim Compatibility* (3 failures) and *Solr 8.11-slim Compatibility* (1 failure). Nothing is skipped: every test runs on every version, asserting that version's behaviour. ## Verification - `./gradlew test --tests '*CollectionServiceIntegrationTest' --tests '*SchemaServiceIntegrationTest' -Dsolr.test.image=solr:10-slim` — 24 tests, 0 skipped, 0 failures - same with `-Dsolr.test.image=solr:8.11-slim` — 24 tests, 0 skipped, 0 failures - `./gradlew build` (default `solr:9.9.0-slim`) — 421 tests, 0 skipped, 0 failures 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
